fix: disable automatic TUI launch (#1066)#1072
Merged
Merged
Conversation
TUI companion auto-launch consumed excessive memory in multi-session (taskMaestro) environments. Remove the launch mechanism from session-start hook, cleanup from stop hook, and delete tui_launcher module and its tests. TUI source code (apps/mcp-server/src/tui/) is preserved for manual use.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Mar 28, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE
CI Status
- ✅ ALL 27/27 checks PASS — including
e2e-plugin-hooks(3.11, 3.12),plugin-test,unit-test-check
Code Quality
- ✅ Clean deletion — no leftover references to
tui_launcherin any remaining code - ✅ No unused imports — all
from tui_launcher importlines removed with their enclosing blocks - ✅ No dead code — complete removal of TUI launch (session-start.py) and cleanup (stop.py) blocks
- ✅ No dangling state — state management code (
_save_state,_load_state) removed with the module
Changed Files (4)
| File | Action | Lines |
|---|---|---|
hooks/lib/tui_launcher.py |
DELETED | -257 |
tests/test_tui_launcher.py |
DELETED | -400 |
hooks/session-start.py |
TUI launch block removed | -16 |
hooks/stop.py |
TUI cleanup block removed | -7 |
Net: -680 lines of dead code removed
Spec Compliance (#1066)
| Acceptance Criteria | Status |
|---|---|
| TUI가 세션 시작 시 자동 실행되지 않음 | ✅ launch block removed from session-start.py |
| 기존 TUI 관련 코드 정리 (dead code 제거) | ✅ tui_launcher.py + test_tui_launcher.py deleted |
| stop hook의 TUI cleanup 로직도 함께 정리 | ✅ cleanup_tui block removed from stop.py |
| 멀티 세션 환경 메모리 사용량 감소 | ✅ No more TUI node processes spawned per session |
Issues Found: 0
Recommendation
APPROVE — 깔끔한 삭제 PR. 680줄의 dead code가 완전히 제거됨. 잔여 참조 없음. 멀티 세션 환경에서 TUI 프로세스로 인한 메모리 낭비 해결. 머지 준비 완료.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session-start.pyhook (Step 7 block)stop.pyhookhooks/lib/tui_launcher.pymodule and its test fileapps/mcp-server/src/tui/) is preserved for manual useCloses #1066
Test plan
yarn prettier --write .— passednpx tsc --noEmit— passed (no type errors)yarn workspace codingbuddy test— 5327 tests passedgrepconfirms no remainingtui_launcherreferences in plugin package